fix(desktop): MCP batch retry via allSettled; drop dead browser-preview guard#3809
Merged
Conversation
Bulk retry/remove of failed MCP servers used Promise.all, so a single rejection abandoned the rest; switch to allSettled so every server is attempted. Replace the CTA guard's fixed-distance regex window with order-independent lookaheads scoped to the .sidebar__new block.
check-browser-preview-stability.mjs was never wired into any CI workflow and had already rotted — its assertions match exact JSX literals down to indentation, so any harmless reformat misfires. Drop the script and its npm entry; UI invariants belong in component tests, not source snapshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes:
CapabilitiesPanel): "Retry all" / "Clean up invalid" usedPromise.all, so one rejected server aborted the rest of the batch. Switched toPromise.allSettledso every server is attempted regardless of individual failures.check-browser-preview-stability.mjswas never referenced by any CI workflow and had already rotted — its assertions match exact JSX literals (down to indentation and prop order), so harmless reformats misfire. Dropped the script and its npm entry. UI invariants belong in component tests, not source-string snapshots.