fix(desktop): strip controller-injected prefixes from chat display (#3720)#3744
Merged
Conversation
# Conflicts: # desktop/sessions.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebases @ashishexee's #3738 onto current main-v2. The only conflict was a trivial import merge in
desktop/sessions.go(main-v2 addedinternal/agent, the PR addedinternal/control) — both are used, so both imports are kept.Strips controller-injected prefixes (
[Plan mode — read-only…]marker,<memory-update>,<background-jobs>blocks) and syntheticRole: "user"messages from the chat display, so agent-mode internals no longer leak into the desktop/TUI transcript.Verification
control.StripComposePrefixescovered byTestStripComposePrefixes(8 sub-cases: plan marker, memory-update, background-jobs, combined, empty-after-strip) — all passgo build ./...,internal/controlandinternal/clitests, and the desktop modulego build ./...all green after the mergeCloses #3738
Credit: @ashishexee