Skip to content

fix(desktop): strip controller-injected prefixes from chat display (#3720)#3744

Merged
esengine merged 2 commits into
main-v2from
fix/3738-strip-compose-prefixes
Jun 10, 2026
Merged

fix(desktop): strip controller-injected prefixes from chat display (#3720)#3744
esengine merged 2 commits into
main-v2from
fix/3738-strip-compose-prefixes

Conversation

@esengine

Copy link
Copy Markdown
Owner

Rebases @ashishexee's #3738 onto current main-v2. The only conflict was a trivial import merge in desktop/sessions.go (main-v2 added internal/agent, the PR added internal/control) — both are used, so both imports are kept.

Strips controller-injected prefixes ([Plan mode — read-only…] marker, <memory-update>, <background-jobs> blocks) and synthetic Role: "user" messages from the chat display, so agent-mode internals no longer leak into the desktop/TUI transcript.

Verification

  • control.StripComposePrefixes covered by TestStripComposePrefixes (8 sub-cases: plan marker, memory-update, background-jobs, combined, empty-after-strip) — all pass
  • Root module go build ./..., internal/control and internal/cli tests, and the desktop module go build ./... all green after the merge

Closes #3738

Credit: @ashishexee

@esengine esengine requested a review from SivanCola as a code owner June 10, 2026 00:15
@github-actions github-actions Bot added desktop Wails desktop app (desktop/**) tui Terminal UI / CLI (internal/cli, internal/control) agent Core agent loop (internal/agent, internal/control) v2 Go rewrite (1.x) — main-v2 branch, active development labels Jun 10, 2026
@esengine esengine merged commit ea44f3a into main-v2 Jun 10, 2026
21 of 22 checks passed
@esengine esengine deleted the fix/3738-strip-compose-prefixes branch June 10, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Core agent loop (internal/agent, internal/control) desktop Wails desktop app (desktop/**) tui Terminal UI / CLI (internal/cli, internal/control) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants