Skip to content

fix(desktop): honor user font in UI chrome#3605

Merged
esengine merged 1 commit into
esengine:main-v2from
jiaxindeyang-a11y:codex/user-font-ui-copy
Jun 9, 2026
Merged

fix(desktop): honor user font in UI chrome#3605
esengine merged 1 commit into
esengine:main-v2from
jiaxindeyang-a11y:codex/user-font-ui-copy

Conversation

@jiaxindeyang-a11y

Copy link
Copy Markdown
Contributor

What

Update desktop UI chrome text to follow the user's selected font family instead of forcing the monospace stack in ordinary interface copy.

This covers visible chrome such as:

  • composer metadata controls
  • status bar text and model/effort switcher controls
  • todo bar title/count
  • settings sidebar descriptions
  • run status text

Technical text surfaces remain monospace: code, diffs, tool output, file paths, hashes, logs, and other identifier-heavy content.

Why

The Appearance -> Font setting already updates the app's --sans stack, but several user-facing labels were pinned to --mono, making them visually inconsistent with composer placeholder/input text such as "给 Reasonix 发消息...".

Testing

  • npm.cmd run check:css
  • npm.cmd run test:all
  • npx.cmd tsc --noEmit -p tsconfig.test.json
  • git diff --check

Note: I attempted to start the Vite dev server for visual QA, but this Windows environment has duplicate Path/PATH environment entries that caused PowerShell process launching to fail. The CSS and frontend test checks above passed.

@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) labels Jun 8, 2026
@jiaxindeyang-a11y jiaxindeyang-a11y marked this pull request as ready for review June 8, 2026 15:34
@jiaxindeyang-a11y

Copy link
Copy Markdown
Contributor Author

Small note on the CSS font-family choices:

Parent UI containers use var(--sans) to follow the selected app font, while nested controls inherit from their local container to avoid reintroducing monospace styling.

@esengine esengine left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed: this is a genuine bug-fix (not a cosmetic UI change) and CI is green. Approving.

@esengine esengine merged commit 368dad0 into esengine:main-v2 Jun 9, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants