fix(desktop): restore maximized window from tray#3568
Merged
esengine merged 2 commits intoJun 8, 2026
Merged
Conversation
Contributor
Author
|
Windows manual verification passed after the follow-up fix: maximized window -> close to tray -> reopen from tray restores directly as maximized, without the normal-size window flash. |
esengine
approved these changes
Jun 8, 2026
esengine
left a comment
Owner
There was a problem hiding this comment.
Verified: background-restore strategy tests pass; nice fix for the maximized-window flash on tray restore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Restore a maximized desktop window to its maximized state after it is hidden to the system tray.
Fixes #3475.
Why
The normal startup path restores
WindowState.Maximised, but the tray restore path only calledWindowShowandWindowUnminimise. On Windows, closing a maximized window to the tray and reopening it therefore restored a non-maximized window.How
Testing
go test . -run 'TestBackground(CloseHideStrategyByPlatform|RestoreMaximiseStrategy)|TestTrayMenuLabelsFollowLocale|TestBeforeCloseAllowsSystemQuitWhenBackgroundCloseEnabled' -count=1wails build(Windows amd64)go test ./...still has three unrelated existing Windows failures: a locked TempDir cleanup, skill path state, and a test filename containing a double quote that Windows rejects.