Skip to content

Fix approval scope reuse / 修复审批授权范围复用#3549

Merged
esengine merged 1 commit into
main-v2from
codex/issue-3498-approval-scopes
Jun 9, 2026
Merged

Fix approval scope reuse / 修复审批授权范围复用#3549
esengine merged 1 commit into
main-v2from
codex/issue-3498-approval-scopes

Conversation

@SivanCola

Copy link
Copy Markdown
Collaborator

Summary

  • Represent remembered approvals as explicit permission rules such as Bash(...), Bash(...:*), and Edit(...), while keeping legacy rule compatibility.
  • Add scoped session and persistent approval handling across desktop, CLI TUI, ACP, and serve UI so similar safe Bash commands and file mutations do not repeatedly prompt.
  • Persist approval rules into project config with coverage/deduplication notices, and update docs plus approval mock artifacts.

Testing

  • go test ./internal/permission ./internal/control ./internal/acp ./internal/i18n ./internal/serve ./internal/config ./internal/boot ./internal/cli
  • npm --prefix desktop/frontend run check:css
  • xmllint --noout docs/assets/approval-authorization-mocks.svg
  • git diff --check

Addresses #3498

@SivanCola SivanCola requested a review from esengine as a code owner June 8, 2026 08:22
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) tui Terminal UI / CLI (internal/cli, internal/control) agent Core agent loop (internal/agent, internal/control) config Configuration & setup (internal/config) and removed v2 Go rewrite (1.x) — main-v2 branch, active development labels Jun 8, 2026

@esengine esengine left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the diff: the fix is correct, focused, and CI is green. Approving for merge.

@esengine esengine merged commit f311a47 into main-v2 Jun 9, 2026
10 checks passed
@esengine esengine deleted the codex/issue-3498-approval-scopes branch June 9, 2026 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Core agent loop (internal/agent, internal/control) config Configuration & setup (internal/config) desktop Wails desktop app (desktop/**) tui Terminal UI / CLI (internal/cli, internal/control)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants