Skip to content

Fix desktop image drag crash / 修复桌面图片拖拽崩溃#3547

Merged
esengine merged 1 commit into
esengine:main-v2from
SivanCola:codex/fix-3543-nondraggable-images
Jun 8, 2026
Merged

Fix desktop image drag crash / 修复桌面图片拖拽崩溃#3547
esengine merged 1 commit into
esengine:main-v2from
SivanCola:codex/fix-3543-nondraggable-images

Conversation

@SivanCola

Copy link
Copy Markdown
Collaborator

Summary

  • mark internal desktop images as non-draggable so dragging the empty-state logo does not start a browser image drag
  • cover adjacent internal image previews/logos to keep Wails file-drop handling reserved for real file drops

Fixes #3543

Verification

  • pnpm --dir desktop/frontend check:css
  • pnpm --dir desktop/frontend typecheck
  • pnpm --dir desktop/frontend build
  • rg -n "<img(?![^>]*draggable=)" desktop/frontend/src -S -P; test $? -eq 1

@SivanCola SivanCola requested a review from esengine as a code owner June 8, 2026 08:07
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) and removed v2 Go rewrite (1.x) — main-v2 branch, active development labels Jun 8, 2026

@esengine esengine left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean fix — draggable={false} on the internal images is the correct way to stop the native drag crash. No new type errors.

@esengine esengine merged commit 6969e96 into esengine:main-v2 Jun 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Wails desktop app (desktop/**)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]:

2 participants