ci(release): keep canary off the GitHub releases page (R2-only)#3531
Merged
Conversation
Canary desktop builds no longer publish a GitHub release — the version showed up on the public releases page looking like a 1.4 stable. Canary now uploads its signed dist as a workflow artifact that the mirror job pushes to R2 (canary/ + desktop-canary/); the updater's canary channel is R2-only. Stable is unchanged. Docs updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The canary acceptance builds published a
desktop-canaryGitHub pre-release titledv1.4.0-canary.N, which showed up on the public releases page and read like a 1.4 stable was out. It wasn't — but it's confusing.This makes desktop canary R2-only:
publishuploads the signed dist as acanary-distartifact,mirrorpulls that artifact and pushes to R2 (canary/+desktop-canary/) as before.latest/.Result: canary never appears on the releases page; testers get the desktop canary from its R2 link. The already-published
desktop-canaryrelease was deleted manually.Verified:
go build/channel test green, YAML valid.