fix(chooser): separate Enter (confirm) from Space (toggle) in multi-s…#3530
Merged
Conversation
…elect Multi-select mode now uses Space only for toggling individual options, while Enter (and number keys) confirms current selections and advances to the next question or submits, matching the single-select flow. Previously both keys toggled, making it impossible to commit without toggling the highlighted option. The desktop AskCard already has this correct via explicit confirm buttons and was unaffected.
Contributor
Author
|
Fixes #3504 |
esengine
approved these changes
Jun 8, 2026
esengine
left a comment
Owner
There was a problem hiding this comment.
Good call separating Space (toggle) from Enter (confirm) in multi-select — verified the toggle path in handleChooserKey and the full cli suite is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…elect
Multi-select mode now uses Space only for toggling individual options, while Enter (and number keys) confirms current selections and advances to the next question or submits, matching the single-select flow. Previously both keys toggled, making it impossible to commit without toggling the highlighted option.
The desktop AskCard already has this correct via explicit confirm buttons and was unaffected.