ci(release): gate stable releases behind esengine approval#3528
Merged
Conversation
Stable publish jobs (CLI goreleaser, npm tag push, desktop tag/stable dispatch) now run in the `release` environment, which requires esengine's approval before anything goes public. Canary dispatches use the open `canary` environment so any maintainer can self-serve a pre-release. Adds docs/RELEASING.md documenting the trunk+tags model, channels, and who can ship what.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locks down who can publish what, the way we agreed: maintainers can cut canary freely; only esengine can ship
next/stable.Mechanism (GitHub-native, free on public repos)
release(esengine = required reviewer) andcanary(open).releaseenvironment, so a stable release — even one a maintainer starts by pushing av*/npm-v*/desktop-v*tag — pauses in the Actions UI until esengine approves.canaryenvironment → any maintainer (write access) self-serves a pre-release, no approval.Gating per workflow
release.yml(CLI + Homebrew):environment: release(tag-triggered, always stable).release-npm.yml:releaseon tag push,canaryon dispatch.release-desktop.yml:canaryonly whenchannel=canarydispatch, elserelease. Gated at thepublishjob so nothing is released/mirrored until approved.Also
docs/RELEASING.md— trunk+tags model, channels, the release loop, and who-can-ship-what.Safety