fix(desktop): classify attachments by real file type#3474
Merged
esengine merged 1 commit intoJun 8, 2026
Merged
Conversation
Treat .reasonix/attachments refs as images only when the attachment is an actual image extension, so yaml/zip attachments resolve as file refs and no longer render as misleading image placeholders. Co-authored-by: Cursor <cursoragent@cursor.com>
esengine
approved these changes
Jun 8, 2026
esengine
left a comment
Owner
There was a problem hiding this comment.
附件按扩展名分类，.yml/.zip 不再被当图片发出；Go/TS 两侧对称、扩展名一致，测试覆盖 png/yml/zip。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.reasonix/attachments/*refs asrefImageonly for real image extensions, so.yml/.zipnow resolve as normal file refsResolveRefsbehavior[image]and non-image attachments as[file:<name>]Fixes #3452.
Test plan
go test ./internal/controlnpm run typecheck(indesktop/frontend)