fix(config): preserve LSP settings on config save#3471
Merged
esengine merged 1 commit intoJun 8, 2026
Conversation
esengine
approved these changes
Jun 8, 2026
esengine
left a comment
Owner
There was a problem hiding this comment.
根因定位准确——注释版 TOML renderer 漏序列化 LSP 段。修法干净,c++ 这类非裸 key 的引号处理也对,round-trip 三 scope 覆盖到位。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[lsp]and[lsp.servers.<lang>]inRenderTOMLForScopesoSaveTopreserves user LSP overrides.c++for deterministic, valid TOML.Root cause
Config.LSPwas loaded correctly, but the annotated TOML renderer never serialized it back out. Any save operation rewrote the config without the LSP section.Validation
go test ./internal/config -count=1go test ./internal/config -run ^$ -bench BenchmarkRenderTOMLWithLSPServers -benchmem -count=5go vet ./...go test ./... -p 1 -count=1internal/cli/TestACPFactoryLoadsSessionCwdProjectConfigstill fails at TempDir cleanup with a file-in-use error outside this render path.go test ./desktop/... -count=1Closes #3464