feat(desktop): add font-family picker with CJK-optimized presets#3378
Merged
Conversation
Default font stack now prioritises PingFang SC / Microsoft YaHei / Noto Sans SC so Chinese text renders consistently on every platform instead of falling back to Song / SimSun on Windows. Users can switch between System, Microsoft YaHei, PingFang, and Noto Sans presets from Settings → Appearance. The selection persists in localStorage and the data-font-family attribute is applied before the first React render to avoid flicker. Closes #3036
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-font-familyHTML 属性 + CSS 变量覆盖实现,在 React 首帧渲染前生效,无闪烁Closes #3036.
How it works
lib/fontFamily.tstextSize.ts模式styles.css[data-font-family="yahei/pingfang/noto"]覆盖规则main.tsxinitFontFamily()在首帧前同步调用SettingsPanel.tsxlocales/*.tsTest plan
cd desktop/frontend && npx tsc --noEmit通过pnpm run build成功