Codex/pr 3251 review fix#3287
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d08580de48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| parts.push({ type: "text", value: s.slice(i, close + 1) }); | ||
| i = close + 1; |
There was a problem hiding this comment.
Keep scanning after non-math dollar pairs
When a non-math dollar amount appears before a real $...$ formula in the same text node, this consumes the formula's opening $ as the closing delimiter for the currency span and then advances past it. For example, Cost is $5 and formula $x+1$ is emitted entirely as text, so the later $x+1$ never gets rendered as math. If the candidate fails isLikelyInlineMath, the parser needs to resume in a way that still lets the later dollar start a valid math span.
Useful? React with 👍 / 👎.
|
Closing alongside #3251. main-v2 already renders math via the remark-math + rehype-katex plugins in Markdown.tsx, so this custom-component approach (a superset of #3251) is now superseded. If non-standard (...) / [...] delimiter support is the gap worth keeping, please open a small focused PR that augments the existing remark-math pipeline rather than replacing it. Thank you! |
No description provided.