Skip to content

refactor(desktop): remove agent settings tab#3201

Merged
esengine merged 3 commits into
main-v2from
codex/settings-temperature-presets
Jun 5, 2026
Merged

refactor(desktop): remove agent settings tab#3201
esengine merged 3 commits into
main-v2from
codex/settings-temperature-presets

Conversation

@SivanCola

@SivanCola SivanCola commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove the standalone Agent section from the desktop Settings drawer
  • drop the settings navigation metadata and locale strings for temperature, max tool rounds, and system prompt editing in that section
  • leave the backend agent config shape intact so runtime controls can be added elsewhere without a config migration

Testing

  • pnpm typecheck (fails: current worktree is missing generated wailsjs modules and has an existing bridge.ts type constraint error)
  • rg check confirmed no SettingsPanel/locale references remain for the removed Agent settings controls
  • attempted local Playwright browser check, but playwright is not installed in this worktree

@github-actions github-actions Bot added the v2 Go rewrite (1.x) — main-v2 branch, active development label Jun 5, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 00f8d0001f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/frontend/src/components/SettingsPanel.tsx Outdated
@SivanCola SivanCola changed the title feat(desktop): add temperature presets refactor(desktop): remove agent settings tab Jun 5, 2026

@esengine esengine left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

纯删除桌面端 Agent 设置 tab,后端 config 形状保留,无悬挂引用;CI desktop/lint 全绿。本地 typecheck 失败仅因 worktree 缺 wailsjs 生成物,与改动无关。合并。

@esengine esengine merged commit 0c020ba into main-v2 Jun 5, 2026
9 checks passed
@esengine esengine deleted the codex/settings-temperature-presets branch June 5, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants