fix(desktop): prevent workspace git console flashes on Windows#2935
Conversation
3d1991a to
4829f23
Compare
|
Thanks for tackling this — the flashing console windows from There's one blocker before I can merge, though. Adding Root cause: Could you drop the |
Keep proc.HideWindow limited to CREATE_NO_WINDOW so shell tools preserve stdout/stderr capture, and add a Windows-only HideWindowDetached helper for desktop workspace git probes that flash console windows from the GUI build. Add proc-level coverage that HideWindow still captures child stdout. Closes esengine#2930
4829f23 to
6badfb0
Compare
|
Updated.
The detached behavior is now scoped only to the desktop workspace git probes that |
Fixes the Windows desktop workspace panel flashing console windows when it runs
git status probes.
This keeps the shared
proc.HideWindowhelper onCREATE_NO_WINDOWonly, soshell tools such as PowerShell keep stdout/stderr capture working. The detached
process behavior is scoped to the desktop workspace git probes via a Windows-only
proc.HideWindowDetachedhelper, with a non-Windows no-op stub.Also adds proc-level regression coverage that
HideWindowstill captures childstdout.
Closes #2930