fix(telegram): bind callback confirmations#2222
Merged
esengine merged 2 commits intoMay 29, 2026
Merged
Conversation
esengine
approved these changes
May 29, 2026
esengine
left a comment
Owner
There was a problem hiding this comment.
This addresses both follow-ups I raised on #2213, and cleanly. Callback data is now tg:${confirmationId}:${choice} (via telegramCallbackData/parseTelegramCallbackData) instead of bare "1", and presses are gated twice: callback.confirmationId !== interactionRef.current.confirmationId rejects a button from a superseded confirmation, and query.message.message_id !== this.activeCallbackMessageId correlates the press to the active prompt — so a stale button can't resolve a newer confirmation. The fail-closed acceptRemoteInput(userId) gate on the callback path is preserved. CI green. Nice hardening — merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"1","2","3"payloads.message_id, so stale buttons from older confirmations cannot resolve a newer prompt.Review Follow-up
This resolves the non-blocking follow-up from #2213 (review):
callbackDatanow includes a confirmation id (tg:<id>:<choice>)Verification
npm run verify