fix(i18n): add missing sendFeedback/skipFeedback/cancelFeedbackLabel/…#2069
Merged
Merged
Conversation
…refineFeedbackLabel keys to ja locale
esengine
approved these changes
May 28, 2026
esengine
left a comment
Owner
There was a problem hiding this comment.
Clean type-check backfill, matches the en/zh-CN/de wording. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds four missing keys (
sendFeedback,skipFeedback,cancelFeedbackLabel,refineFeedbackLabel) todesktop/src/i18n/ja.tsthat were recently addedto
en.ts.Why
The strict TranslationSchema type check in
i18n/index.tsfails the desktopbuild when any locale doesn't match the shape of
en.ts.How to verify
cd desktop && npm run tauri build -- --bundles dmgcompiles without typeerrors in
src/i18n/index.ts:111.Checklist
npm run verifypasses locallyCo-Authored-By: Claudetrailer in commitsCHANGELOG.md