chore(theme): finish theme rename follow-up after #1666#1678
Merged
Conversation
#1666 renamed/dropped themes (tokyo-night → midnight, removed default/github-dark/github-light, added deep-blue) but missed three surfaces: - `/theme` slash command's `argsHint` and `argCompleter` still advertised the removed names and were missing `midnight` / `deep-blue` - i18n `themeCaption` dicts in EN.ts and zh-CN.ts still held the removed entries and had no labels for the new themes, so the picker would render the literal i18n key (e.g. `wizard.themeCaption.midnight`) next to the new theme names Drop the stale entries from both locales, add captions for `midnight` and `deep-blue`, and trim the slash command lists to the actual theme set. The "default" caption is gone because the theme itself was removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up cleanup after #1666 — that PR renamed/dropped themes (
tokyo-night→midnight, removeddefault/github-dark/github-light, addeddeep-blue) but missed three surfaces:src/cli/ui/slash/commands.ts:97—/themeslash command'sargsHintandargCompleterstill advertised the removed names and were missingmidnight/deep-bluesrc/i18n/EN.ts:450andsrc/i18n/zh-CN.ts:432—themeCaptiondicts still held entries for the removed themes and had no labels for the new themes, so the picker would render the literal i18n key (e.g.wizard.themeCaption.midnight) next to the new theme namesDrop the stale entries from both locales, add captions for
midnightanddeep-blue, and trim the slash command lists to the actual theme set.Test plan
grepconfirms zero remaining references to removed theme names insrc/cli/ui/slashandsrc/i18nnpx tsc --noEmitnpx vitest run tests/slash.test.ts tests/theme-tokens.test.ts tests/config.test.ts— 224 passed / 1 skipped