chore(ui): drop redundant overflow-wrap from inherited descendants#1675
Merged
Conversation
overflow-wrap is an inherited property; .msg-text already declares it, so the duplicate declarations on .msg-text .markdown and .msg-text p are noise. The combined `.msg-text X, .markdown X` selectors keep their declarations because the standalone .markdown case (cards) has no ancestor setting overflow-wrap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
overflow-wrapis an inherited CSS property, and.msg-textalready declaresoverflow-wrap: anywhere(added in #1590). The duplicate declarations on.msg-text .markdownand.msg-text pcascade no behavior change — they only add noise.Removed in both
desktop/src/styles.cssanddashboard/src/styles.css. The combined.msg-text X, .markdown Xselectors (code, links) keep their declarations because the standalone.markdowncase (used in cards, outside.msg-text) has no ancestor settingoverflow-wrap.Verification
npm run verify✅npm exec vitest run tests/user-message-newlines.test.ts✅