fix(desktop): Esc closes modal instead of aborting model when settings/about/jobs is open#1670
Closed
CVEngineer66 wants to merge 3 commits into
Closed
fix(desktop): Esc closes modal instead of aborting model when settings/about/jobs is open#1670CVEngineer66 wants to merge 3 commits into
CVEngineer66 wants to merge 3 commits into
Conversation
4 tasks
Owner
|
Took the focused Esc-skip-when-modal-open + active-session-click-guard parts and shipped them as #1685 (merged), co-authored credit preserved. Dropping this branch because it was based on a pre-#1657 / pre-#1666 / pre-#1667 commit — squash-merging would have silently rolled back the preset drop, the four reasoning-effort options, and the Closing in favor of #1685. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a modal (settings, about, jobs) is open during model streaming,
pressing Esc was calling abort() instead of closing the modal.
Also fixes #1653: clicking the current session in the sidebar no longer
triggers a session reload that clears live state.
Changes
JobsPop and WorkdirPop already had their own Esc handlers.
Verification