Summary

Wire editMode = "plan" into the actual tool dispatch gate so plan mode is truly read-only, including in desktop sessions, and clean up stale desktop preset wiring that was breaking typecheck.

Problem

editMode = "plan" was being saved and surfaced in the UI, but it did not reliably enable ToolRegistry.planMode, which is the layer that actually blocks mutating tools like write_file, edit_file, and multi_edit.

This meant the desktop app could show or persist plan mode while the active tool registry still allowed file writes.

There was also stale desktop dashboard preset code in App.tsx referencing removed APIs and fields:

• autoEscalate
• setProNextLive
• armProForNextTurn
• disarmPro

Those references no longer exist in the current preset / loop types and caused npm run typecheck to fail.

Fix

• src/code/setup.ts — Added applyPlanMode() and call it during buildCodeToolset() so editMode = "plan" initializes ToolRegistry.planMode.
• src/cli/commands/desktop.ts — Synchronized desktop runtime/toolset state when edit mode is loaded, emitted, or changed via settings, so switching to plan mode takes effect immediately.
• src/cli/ui/App.tsx — Removed stale autoEscalate / pro-next dashboard wiring and aligned preset handling with the current flash | pro model.
• tests/code-setup-lazy-subagent.test.ts — Added a regression test proving buildCodeToolset() blocks write_file when config edit mode is plan.
• tests/config.test.ts and tests/welcome-banner-hints.test.tsx — Removed stale unused Biome suppressions that made lint fail.

Verification