Skip to content

test(lifecycle): cover npm package aliases#1621

Merged
esengine merged 1 commit into
esengine:mainfrom
GTC2080:GTC/lifecycle-policy-npm-aliases
May 23, 2026
Merged

test(lifecycle): cover npm package aliases#1621
esengine merged 1 commit into
esengine:mainfrom
GTC2080:GTC/lifecycle-policy-npm-aliases

Conversation

@GTC2080

@GTC2080 GTC2080 commented May 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • cover npm i and npm un as package mutation aliases in the lifecycle policy corpus
  • classify both aliases as high-risk package mutation commands, matching npm install and npm uninstall

Validation

  • npm test -- tests/lifecycle-policy.test.ts
  • npm test -- tests/lifecycle-policy.test.ts tests/lifecycle.test.ts tests/tools.test.ts
  • npx tsc --noEmit
  • npm run lint (passes with the existing unused suppression warning in tests/welcome-banner-hints.test.tsx)

Notes

npm run typecheck / push hook full npm run verify is blocked in this local checkout by missing dashboard dependencies such as prism-react-renderer, lucide-react, react-markdown, and related type declarations. The root tsc --noEmit check passes.

@esengine

Copy link
Copy Markdown
Owner

Real gap — npm i would slip past the approval gate. Tight scope, clean tests. Merging.

@esengine esengine merged commit f459dbf into esengine:main May 23, 2026
4 checks passed
@GTC2080 GTC2080 deleted the GTC/lifecycle-policy-npm-aliases branch May 31, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants