fix(memory): JobRegistry self-cleanup for completed jobs#1620
Merged
Conversation
- Auto-evict oldest completed jobs when count exceeds MAX_COMPLETED_JOBS (20) - Cleanup runs on job completion (settleClosed) and list() calls - No time throttle — gate on count only, O(jobs.size) is trivial at N=20 - Initialize lastCleanupAt to 0 so first call always runs (fixes dead zone) Fixes esengine#1571 (JobRegistry portion)
Owner
|
Clean split — narrow diff, both blockers addressed, no time-throttle dead zone since the throttle itself is gone. Merging. |
This was referenced May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JobRegistry Self-Cleanup
Fixes #1571 (JobRegistry portion)
Problem
Completed jobs accumulate in the JobRegistry Map indefinitely, retaining 64KB output buffers and ChildProcess references. Over a long session, this pins several MB of memory.
Fix
Auto-evict oldest completed jobs when count exceeds MAX_COMPLETED_JOBS (20).
Key decisions per author feedback:
MAX_COMPLETED_JOBS = 20— model doesn't need 50 historical entrieslastCleanupAtinitialized to0so first call always runs (no dead zone)Changes
src/tools/jobs.ts: AddedmaybeCleanup()method, called fromsettleClosedandlist()Testing