fix(desktop): preserve compact composer default#1594
Merged
esengine merged 2 commits intoMay 23, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the desktop chat composer taking too much vertical space by restoring its compact default height, while keeping autosize behavior for multi-line input. Also widen the desktop chat and composer area when both side rails are collapsed, so the center content uses available space more effectively.
Problem
A previous desktop composer autosize change interpreted “fewer than 5 lines: maintain default height” as “make the default height 5 lines.” This increased the empty/default composer from the original 2-line height to a 5-line height, reducing the visible chat area and making responses harder to read.
The issue is in the desktop composer sizing path:
desktop/src/ui/composer-sizing.tssetDEFAULT_COMPOSER_ROWS = 5desktop/src/ui/composer.tsxusesrows={DEFAULT_COMPOSER_ROWS}desktop/src/styles.cssset.composer textareamin-heightto 5 rowstests/desktop-composer-autosize.test.tsencoded the inflated 5-row default as expected behaviorUsers also reported that after collapsing the left and right desktop rails, the chat content still stayed capped around
740px, leaving too much unused horizontal space.The layout width issue is in:
desktop/src/styles.css.thread-innercapped at740pxdesktop/src/styles.css.composer-innercapped at760pxFix
desktop/src/ui/composer-sizing.ts— Restored the default composer height to 2 rows and introducedAUTOSIZE_COMPOSER_ROWS = 5as the threshold where autosizing begins.desktop/src/styles.css— Restored the textarea defaultmin-heightto 2 rows.tests/desktop-composer-autosize.test.ts— Updated regression coverage so input below the 5-line autosize threshold keeps the original compact default height, and 5+ lines expand as intended.desktop/src/styles.css— Added collapsed-rail CSS variables so normal three-column layout keeps the readable740px/760pxcaps, while both-rails-collapsed layout widens chat content to1120pxand composer content to1040px.Verification
npm test -- tests/desktop-composer-autosize.test.tsnpm test -- tests/desktop-composer-autosize.test.ts desktop/src/App.test.tsnpm run linttests/welcome-banner-hints.test.tsxunused suppression warningnpm run verifyClosed #1566