fix(client): wire timeoutMs to fetch when caller passes a signal#1553
Merged
Conversation
`opts.signal ?? ctrl.signal` orphaned the timer's controller whenever the loop forwarded its `_turnAbort.signal` — i.e. every real call. A genuinely stalled SSE body (TCP open, no `[DONE]`, no close) then sat on `reader.read()` forever and the TUI hung in "…waiting for response…" until the user restarted it, even though the server-side request had already completed. Combine both signals with `AbortSignal.any` and have the timer abort with a reason so the loop's error path surfaces "timed out after Xms" instead of a silent stall. Closes #1535
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opts.signal ?? ctrl.signalinchat()andstream()orphaned the timeout controller whenever the loop forwarded its_turnAbort.signal— i.e. every real call — sotimeoutMswas dead code on the hot path.[DONE], no close) then sat onreader.read()forever and the TUI hung in "…waiting for response…" until the user restarted it, even though the DeepSeek dashboard already showed the request as completed.AbortSignal.anyand abort with a reason so the loop's error path surfaces "timed out after Xms" instead of a silent stall.Test plan
tests/client-stream-timeout.test.ts— stream() and chat() both abort on timeout when caller passes a signal, and the caller's own signal still aborts the streamnpm run verifypasses (3544 tests)Closes #1535