fix(desktop): gate success chime on turn outcome

SivanCola · SivanCola · commit 2eba1810fb81 · 2026-06-12T19:06:45.000+08:00
diff --git a/desktop/frontend/src/App.tsx b/desktop/frontend/src/App.tsx
@@ -25,7 +25,7 @@ import { useToast } from "./lib/toast";
 import { asArray } from "./lib/array";
 import { clearLegacyLangPref, normalizeLangPref, readLegacyLangPref, useI18n, useT, type Translator } from "./lib/i18n";
 import { useController, type Item, type LiveStream } from "./lib/useController";
-import { app, onEvent, onProjectTreeChanged, onTurnDone } from "./lib/bridge";
+import { app, onEvent, onProjectTreeChanged } from "./lib/bridge";
 import { playSuccessChime } from "./lib/sound";
 import { Transcript } from "./components/Transcript";
 import { Composer } from "./components/Composer";
@@ -709,19 +709,12 @@ export default function App() {
     const unsub = onEvent((e) => {
       if (e.kind === "turn_done") {
         setDockRefreshKey((v) => v + 1);
+        if (!e.err) playSuccessChime();
       }
     });
     return unsub;
   }, []);
 
-  // Play a success chime when any turn finishes.
-  useEffect(() => {
-    const unsub = onTurnDone(() => {
-      playSuccessChime();
-    });
-    return unsub;
-  }, []);
-
   const [workspacePanelResizing, setWorkspacePanelResizing] = useState(false);
   const [workspacePanelMaximized, setWorkspacePanelMaximized] = useState(false);
   const [rightDockMode, setRightDockMode] = useState<RightDockMode>("context");
diff --git a/desktop/frontend/src/lib/bridge.ts b/desktop/frontend/src/lib/bridge.ts
@@ -393,14 +393,6 @@ export function onProjectTreeChanged(cb: () => void): () => void {
   return () => {};
 }
 
-/** Fires when any topic's generation finishes (TurnDone). Used for sound. */
-export function onTurnDone(cb: () => void): () => void {
-  if (realApp() && typeof window !== "undefined" && window.runtime) {
-    return window.runtime.EventsOn("agent:turn-done", () => cb());
-  }
-  return () => {};
-}
-
 // app proxies each call to the live binding (or the dev mock only when truly
 // outside the shell), so a late-injected window.go is picked up transparently.
 export const app: AppBindings = new Proxy({} as AppBindings, {
diff --git a/desktop/tabs.go b/desktop/tabs.go
@@ -226,9 +226,6 @@ func (s *tabEventSink) Emit(e event.Event) {
 	}
 	if s.ctx != nil {
 		runtime.EventsEmit(s.ctx, eventChannel, toWireTab(e, s.tabID))
-		if e.Kind == event.TurnDone {
-			runtime.EventsEmit(s.ctx, "agent:turn-done")
-		}
 	}
 	if s.app != nil {
 		if status, update := topicActivityStatusFromEvent(e); update && s.app.setTabActivityStatus(s.tabID, status) {

Original file line number	Diff line number	Diff line change
`@@ -226,9 +226,6 @@ func (s *tabEventSink) Emit(e event.Event) {`
`226`	`226`	`}`
`227`	`227`	`if s.ctx != nil {`
`228`	`228`	`runtime.EventsEmit(s.ctx, eventChannel, toWireTab(e, s.tabID))`
`229`		`- if e.Kind == event.TurnDone {`
`230`		`- runtime.EventsEmit(s.ctx, "agent:turn-done")`
`231`		`- }`
`232`	`229`	`}`
`233`	`230`	`if s.app != nil {`
`234`	`231`	`if status, update := topicActivityStatusFromEvent(e); update && s.app.setTabActivityStatus(s.tabID, status) {`