Skip to content

fix(parser): support parsing expressions in extend clause #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
h13i32maru merged 1 commit into from
Sep 3, 2017
Merged

fix(parser): support parsing expressions in extend clause #409

h13i32maru merged 1 commit into from
Sep 3, 2017

Conversation

@dimitryvolkov
Copy link
Contributor

@dimitryvolkov dimitryvolkov commented Mar 29, 2017 •
edited
Loading

Currently esdoc fails for code containing a call expression in 'extends' clauses which is a supported feature and is popular with mixins.

Failing code:

function mix() {
	return {
		with: function () {
			return class { };
		}
	};
}
class Test extends mix().with() { }

h13i32maru
h13i32maru approved these changes Sep 3, 2017
View reviewed changes
Copy link
Member

@h13i32maru h13i32maru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@h13i32maru h13i32maru merged commit 33d9c39 into esdoc:master Sep 3, 2017
@oravecz
Copy link

oravecz commented Sep 5, 2017

What should this PR allow? I didn't see any change in my web component docs which are using mixins using a different approach.

Should this PR allow the identifications of mixins when implemented such as these techniques?

class Test extends Mixin1( Mixin2( HTMLElement ) )

or a Composable implementation

class Test extends Composable(HTMLElement).compose( Mixin1, Mixin2 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@h13i32maru h13i32maru h13i32maru approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dimitryvolkov @oravecz @h13i32maru