fixed a memory leak that caused the pe file to be access locked.#386
Merged
erocarrera merged 1 commit intoerocarrera:masterfrom Jan 11, 2024
Merged
Conversation
Owner
|
Thanks!, I've checked and this change frees plenty of unreachable objects upon close. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes an issue similar to #356 that exists when using with python312 and 311, I didn't test with other versions.
couldn't find where the leak is, so
gc.collect()from the gc module is used at the end of the_close_data()function to clear all unreachable and uncollected memory and release the file access lock.