Loosen export symbol validation:#360
Merged
erocarrera merged 1 commit intoerocarrera:masterfrom Feb 1, 2023
Merged
Conversation
- Allow more symbols in export names - Allow exports with an RVA of '0'
Contributor
Author
|
@erocarrera is there anything I can do to help get this merged? |
Contributor
Author
|
Thanks! |
Owner
|
Thanks for the PR, I made a change so that the updated loosened validation only applies when parsing exports and not when parsing imports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was noticed with the '%' symbol in exports from a delphi .bpl file.
The rest of the symbols were obtained by simply trying all (readable) ascii chars in a .def file, and linking with VS 2022's link.exe
Everything that did not produce a valid symbol was eliminated.