Closed
Conversation
When building with optimization flag enable, it is possible to generate symbol names such as 'PyErr_CheckSignals.part.0' which contain a dot. Simply add '.' to the allowed_function_name list.
Owner
|
Thanks, this was addressed in #346 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Although it is indeed forbidden as part of function names, the dot character is allowed as part of a symbol name. This happens for instance when building with optimization flags.
I stumbled upon such a case with mingw64's libpython3.7m.dll (compiled as described here: https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-python3/PKGBUILD).
I've uploaded a copy of the resulting library here for your convenience : https://gist.github.com/GabrielGanne/682807a60f8eb537f6a9f2e674c84308
The expected symbol output should be as follow: