Conversation
Pull Request Test Coverage Report for Build 8928600899abad2afdd608ef2897e01ee3f16039-PR-20Details
💛 - Coveralls |
Member
Author
|
@matt-phylum Do you have time for a review of this? You seem to know your way around purl quite well :) I saw that there's some ongoing discussions in the Purl Spec repo around escaping. That probably should be cleaned up a bit. (For example: are Right now the code is passing different characters around for each field. The current state passes the tests and I can test the property |
matt-phylum
reviewed
Mar 4, 2025
Contributor
matt-phylum
left a comment
There was a problem hiding this comment.
LGTM I'm not an Elixir expert and I didn't verify that the sets of characters being encoded are exactly right according to the spec, but they're probably right if you're passing tests.
Member
Author
|
Thanks for the review @matt-phylum :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.