Skip to content

ssl: Add more guards to api functions#8156

Merged
dgud merged 1 commit intoerlang:masterfrom
dgud:dgud/ssl/check-args/GH-8066
Feb 21, 2024
Merged

ssl: Add more guards to api functions#8156
dgud merged 1 commit intoerlang:masterfrom
dgud:dgud/ssl/check-args/GH-8066

Conversation

@dgud
Copy link
Copy Markdown
Contributor

@dgud dgud commented Feb 19, 2024

Gives badarg earlier instead of strange crashes/error messages later.

Closes #8066

@dgud dgud self-assigned this Feb 19, 2024
@dgud dgud requested review from IngelaAndin and u3s February 19, 2024 16:20
@dgud dgud added the team:PS Assigned to OTP team PS label Feb 19, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 19, 2024

CT Test Results

    2 files     67 suites   48m 44s ⏱️
  786 tests   753 ✅  33 💤 0 ❌
3 757 runs  2 982 ✅ 775 💤 0 ❌

Results for commit 278a98f.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@dgud dgud added the testing currently being tested, tag is used by OTP internal CI label Feb 20, 2024
Gives function_clause earlier instead of strange crashes/error messages later.
@dgud dgud force-pushed the dgud/ssl/check-args/GH-8066 branch from d420ad0 to 278a98f Compare February 20, 2024 13:33
@dgud dgud merged commit 9c69570 into erlang:master Feb 21, 2024
@lukebakken
Copy link
Copy Markdown
Contributor

Thank you @dgud!

@dgud dgud deleted the dgud/ssl/check-args/GH-8066 branch April 30, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verification of ssl client / server options could be more user friendly

4 participants