jinterface: Allow to build determenistic OtpErlang.jar#10556
jinterface: Allow to build determenistic OtpErlang.jar#10556sverker merged 1 commit intoerlang:masterfrom
Conversation
CT Test Results 2 files 13 suites 5m 0s ⏱️ Results for commit ed91c31. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
|
|
|
Edit: CLA signing did work now. The original comment was: It seems, signing the CLA does not work anymore. However, let me certify hereby that: |
c631605 to
3a25efe
Compare
|
We got this build error and then the entire jar file seems to be dumped to stdout. I pushed a fixup commit where it uses the dash-less syntax instead: |
|
That fix did not work. On the other hand, I don't know why our docker build does not like |
|
Maybe the docker build uses some other jar version/implementation? I remember other projects had trouble because busybox-tar was used. |
|
@bmwiedemann This seems to work on all our test machines. Ok? |
|
Yes, it also works in my tests. Good to merge. |
This is a simpler alternative to PR erlang#5580 It lets us get closer to reproducible builds for erlang. See https://reproducible-builds.org/ for why this is good. Note: when using options with double-dash, jar does not understand merged options such as -cf anymore so we have to split them up to work again. Note2: we hardcode the date, because the complexity of converting seconds to a date string to work on all OSes is not worth it. Closes erlang#5580
|
Ticket: OTP-19956 |
This is a simpler alternative to PR #5580
It lets us get closer to reproducible builds for erlang. See https://reproducible-builds.org/ for why this is good.
Note: when using options with double-dash,
jar does not understand merged options such as -cf anymore
so we have to split them up to work again.
Closes #5580