159: enhancement: Use typed response structs instead of raw serde_json::Value#184
Merged
159: enhancement: Use typed response structs instead of raw serde_json::Value#184
Conversation
Replace 10 standalone functions with methods on GitHubClient which encapsulates remote parsing, token resolution, HTTP client creation, and standard header injection. Callers now construct a client once and reuse it for multiple API calls. Closes #152 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduce private Deserialize structs (ApiPr, ApiCombinedStatus, ApiReview, ApiCheckRunsResponse, ApiMergeResponse, ApiCreateResponse, ApiPrListItem) to replace all serde_json::Value usage in GitHubClient method bodies. This eliminates fragile string-keyed indexing (e.g. resp["title"].as_str()) in favor of compile-time checked struct field access, improving type safety and making API contract changes caught at compile time. Closes #159 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enhancement: Use typed response structs instead of raw serde_json::Value
Ticket: 159
Shipped via
parsec ship 159