Skip to content

fix: warn on silent branch deletion failures #105

@erishforG

Description

@erishforG

Problem

Multiple places in the codebase silently ignore branch deletion failures with let _ =:

  • github/mod.rs:459 — remote branch deletion via API (causes stale remote branches)
  • commands.rs:716,1088 — local branch deletion after merge/undo
  • manager.rs:405,462 — local branch deletion after clean/ship

Users see no feedback when these fail, leading to confusion (e.g., stale branches in GitKraken).

Solution

Replace let _ = with if let Err(e) = ... { eprintln!("warning: ...") } for branch deletion operations. Keep let _ = for best-effort operations (lock files, rebase --abort).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions