Fix chart zero lines, collection log server name, and overview status (#85, #91, #93)#95
Merged
erikdarlingdata merged 2 commits intodevfrom Feb 17, 2026
Merged
Conversation
…re-firing AddWithValue infers types incorrectly — for DateTime it sends legacy datetime (3.33ms precision) instead of datetime2, causing the deadlock dedup cutoff to round and re-collect the same event every cycle. Replaced all 28 usages across 7 files with explicitly typed SqlParameter. Fixed alert re-firing: ServerTab used CollectionTime (always new) instead of DeadlockTime/EventTime for ack comparison. Overview deadlock count query also filtered by collection_time instead of deadlock_time, inflating counts with duplicate rows and triggering spurious popup alerts. Tested: zero AddWithValue remaining, all 3 projects build clean, dedup confirmed working under HammerDB load (97 new deadlocks collected, zero duplicates). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… status (#85, #91, #93) #85: Blocking/deadlock trend charts now show a visible flat line at zero instead of empty space. Added negative Y-axis margin so zero-value data renders above the axis border. Reduced fallback Y range from +100 to +1. #91: Added server_name column to collection_log DuckDB table (schema v10) so log entries identify which server produced them without a lookup join. #93: Sidebar status dots now reflect actual connection check results (IsOnline) instead of the IsEnabled user config toggle. Added IsOnline property to ServerConnection model, synced from connection status in RefreshServerList and CheckConnectionsAndNotify. Fixed first-check refresh so dots update as soon as initial connection checks complete. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server_namecolumn tocollection_logDuckDB table (schema v10) so log entries identify which server produced them.IsOnline) instead of theIsEnableduser config toggle. Fixed first-check refresh timing.Test plan
🤖 Generated with Claude Code