Fix DuckDB migration ordering after archive-and-reset#314
Merged
erikdarlingdata merged 1 commit intodevfrom Feb 26, 2026
Merged
Fix DuckDB migration ordering after archive-and-reset#314erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
The previous fix (PR #313) moved CREATE TABLE before migrations, but migrations v2/v6/v7/v8 DROP TABLE IF EXISTS then expect CREATE TABLE to follow — so tables were created then immediately dropped. Correct fix: skip migrations entirely on fresh/reset databases (v0). When existingVersion is 0, there's nothing to migrate — just create tables with the current schema and stamp the version. Fixes CI test failures: InitializeAsync_CreatesAllTables, InitializeAsync_CreatesIndexes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DROP TABLE IF EXISTS— so tables were created then immediately dropped on fresh databasesexistingVersion == 0(fresh/reset DB has nothing to migrate)Test plan
dotnet test Lite.Tests— all 6 tests pass (includingInitializeAsync_CreatesAllTablesandInitializeAsync_CreatesIndexesthat were failing on CI)🤖 Generated with Claude Code