Fix installer upgrade bugs and add Agent job cleanup#298
Merged
erikdarlingdata merged 1 commit intodevfrom Feb 25, 2026
Merged
Conversation
- Fix TRUNCATE TABLE using three-part name to avoid master context error when --reset-schedule is used (both CLI and GUI installers) - Fix Version comparison bug: normalize to 3-part versions to avoid Revision=-1 vs Revision=0 mismatch breaking upgrade detection (both installers) - Fix GUI installer upgrade detection: use AppAssemblyVersion instead of AppVersion (which includes +commithash suffix that breaks Version.TryParse) - Add SQL Agent job cleanup (all 3 jobs) to Dashboard's DropMonitorDatabaseAsync so removing a server doesn't leave orphaned erroring jobs - Update RemoveServerDialog text to mention Agent job removal Tested: fresh install, v1.3.0→v2.0.0 upgrade, and idempotent re-run on sql2016 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[PerformanceMonitor].[config].[collection_schedule]to avoid master context error when--reset-scheduleis used (both CLI and GUI installers)Versioncomparison bug: normalize to 3-part versions to avoidRevision=-1vsRevision=0mismatch that silently skipped upgrade scripts (both installers)AppAssemblyVersion(clean2.0.0.0) instead ofAppVersion(includes+commithashsuffix that breaksVersion.TryParse)DropMonitorDatabaseAsyncso removing a server doesn't leave orphaned erroring jobsTest plan
🤖 Generated with Claude Code