Issue #287: Use database_query_store_options for QS detection#292
Merged
erikdarlingdata merged 1 commit intodevfrom Feb 25, 2026
Merged
Issue #287: Use database_query_store_options for QS detection#292erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
…e_on sys.databases.is_query_store_on can be out of sync with reality on Azure SQL DB, reporting 0 when Query Store is actually enabled. Replace the filter with a per-database check against sys.database_query_store_options.actual_state, which reflects the true state. The EXISTS pattern handles empty views, NULL, and disabled states cleanly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sys.databases.is_query_store_onwithsys.database_query_store_options.actual_state > 0for detecting Query Store-enabled databasesis_query_store_onreports0when QS is actually enabledEXISTSpattern that handles empty views, NULL, and disabled states cleanlyRemoteCollectorService.QueryStore.cs) and Dashboard collector (09_collect_query_store.sql)Closes #287
Test plan
EXISTSpattern is null-safe: no rows,actual_state = 0, andactual_state IS NULLall correctly skip the database🤖 Generated with Claude Code