Skip to content

Update nuget again#238

Merged
erikdarlingdata merged 3 commits intoerikdarlingdata:devfrom
MisterZeus:update-nuget-again
Feb 23, 2026
Merged

Update nuget again#238
erikdarlingdata merged 3 commits intoerikdarlingdata:devfrom
MisterZeus:update-nuget-again

Conversation

@MisterZeus
Copy link
Contributor

@MisterZeus MisterZeus commented Feb 23, 2026

What does this PR do?

Updates a few NuGet packages,
swaps deprecated xunit for xunit.v3,
fixes a few new warnings

Which component(s) does this affect?

  • Full Dashboard
  • Lite Dashboard
  • Lite Tests
  • SQL collection scripts
  • CLI Installer
  • GUI Installer
  • Documentation

How was this tested?

ran full solution builds in VS and the build-all.cdm script, no warnings.

Checklist

  • I have read the contributing guide
  • My code builds with zero warnings (dotnet build -c Debug)
  • I have tested my changes against at least one SQL Server version N/A this change only affects thw Lite.Tests project, all 6 tests still pass.
  • I have not introduced any hardcoded credentials or server names

xunit is deprecated, they reccomend using xunit.v3 instead.
warning xUnit1051: Calls to methods which accept CancellationToken should use TestContext.Current.CancellationToken to allow test cancellation to be more responsive. (https://xunit.net/xunit.analyzers/rules/xUnit1051)
@erikdarlingdata
Copy link
Owner

Thanks for the contribution @MisterZeus!

Verification results:

  • Full solution builds with 0 warnings, 0 errors
  • All 6 Lite.Tests pass on xunit.v3

Package audit:

Package Old New Assessment
Microsoft.NET.Test.Sdk 17.10.0 18.0.1 Safe — standard test infrastructure update
xunitxunit.v3 2.8.1 3.2.2 Safe — xunit v2 is deprecated, v3 is the supported path. TestContext.Current.CancellationToken usage is correct.
xunit.runner.visualstudio 2.8.1 3.1.5 Safe — matches xunit.v3

The code changes look clean — the CancellationToken.NoneTestContext.Current.CancellationToken swap is the right pattern for xunit v3, and the PR template improvements are reasonable.

One process note: Please open an issue before submitting PRs so there's visibility into what's being worked on and we can discuss the approach before code is written. This helps avoid duplicate effort and ensures alignment on direction. Thanks!

@erikdarlingdata erikdarlingdata merged commit 0f45722 into erikdarlingdata:dev Feb 23, 2026
4 checks passed
@MisterZeus MisterZeus deleted the update-nuget-again branch February 23, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants