Fix sidebar alert badge not syncing with sub-tab dismissals#214
Merged
erikdarlingdata merged 1 commit intodevfrom Feb 20, 2026
Merged
Fix sidebar alert badge not syncing with sub-tab dismissals#214erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
When dismissing alerts from inside a server tab (right-clicking Locking, Memory, etc.), the sidebar Alerts badge count was not updated because ServerTab only called AlertStateService.AcknowledgeAlert (tab badges) without touching the EmailAlertService alert log (sidebar badge source). Added AlertAcknowledged event on ServerTab, fired after sub-tab dismiss. MainWindow subscribes and hides email alerts + refreshes sidebar badge, matching the landing page dismiss flow. Note: the sidebar badge re-notification follows a 5-minute cooldown per alert type per server — this is by design to avoid notification spam. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AlertStateService.AcknowledgeAlert(tab badges) but never touchedEmailAlertService(sidebar badge source)AlertAcknowledgedevent on ServerTab; MainWindow subscribes and hides email alerts + refreshes sidebar badgeNote
The sidebar badge re-notification follows a 5-minute cooldown per alert type per server. If an alert condition persists after dismissal, the badge reappears after cooldown expires. This is by design to avoid notification spam.
Test plan
🤖 Generated with Claude Code