Fix numeric filter negative range parsing and MCP shutdown deadlock risk#207
Merged
erikdarlingdata merged 1 commit intodevfrom Feb 20, 2026
Merged
Fix numeric filter negative range parsing and MCP shutdown deadlock risk#207erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
NumericFilterHelper: Replace naive Split('-') range parsing with TryParseRange
that finds the separator dash by looking for a '-' preceded by a digit. Correctly
handles -100-200, -100--50, and .. syntax. Previously, negative-start ranges were
silently ignored due to the StartsWith('-') guard.
MainWindow: Wrap MCP StopAsync in Task.Run to avoid sync-over-async deadlock on
the WPF UI thread during app close.
Addresses items from #113 and #112.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split('-')range parsing withTryParseRangethat finds the separator dash by looking for a-preceded by a digit. Correctly handles-100-200,-100--50, and..syntax. Previously, negative-start ranges were silently ignored.StopAsyncinTask.Runto avoid sync-over-async deadlock on the WPF UI thread during app close.Test plan
100-500)🤖 Generated with Claude Code