Fix sidebar alert badge not clearing on acknowledge (fixes #186)#191
Merged
erikdarlingdata merged 1 commit intodevfrom Feb 20, 2026
Merged
Fix sidebar alert badge not clearing on acknowledge (fixes #186)#191erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
AcknowledgeServerAlerts_Click only updated AlertStateService (tab badges) but never hid alerts in EmailAlertService, so the sidebar Alerts button badge count stayed unchanged. Now also hides alerts for the acknowledged server and refreshes the badge. Alert History dismiss actions also immediately update the sidebar badge via an AlertsDismissed event. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AlertsDismissedeventRoot cause:
AcknowledgeServerAlerts_Clickonly updatedAlertStateService(per-tab badges) but never calledEmailAlertService.HideAllAlerts(), leaving the sidebar badge unchanged until the next timer tick — which then re-counted the same unhidden alerts.Test plan
🤖 Generated with Claude Code