Fix NOC deadlock severity dot showing green during active deadlocks#174
Merged
erikdarlingdata merged 1 commit intodevfrom Feb 19, 2026
Merged
Fix NOC deadlock severity dot showing green during active deadlocks#174erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
DeadlockSeverity was only checking the perfmon counter delta between poll cycles, so deadlocks that occurred before Dashboard startup or between the first two polls showed green. Now also checks LastDeadlockMinutesAgo from extended events: <=10 min = Critical, <=60 min = Warning. Added missing OnPropertyChanged notification so the severity dot updates when the timestamp arrives. Closes #170 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeadlockSeveritynow checksLastDeadlockMinutesAgo(from extended events) in addition to the perfmon counter deltaOnPropertyChanged(nameof(DeadlockSeverity))in theLastDeadlockMinutesAgosetter so the dot updates when the XE timestamp arrivesCloses #170
Test plan
🤖 Generated with Claude Code