Fix DuckDB IO errors from concurrent file access#164
Merged
erikdarlingdata merged 1 commit intodevfrom Feb 19, 2026
Merged
Conversation
Three fixes for "DuckDBOpen failed: Cannot open file" errors introduced by PR #159 (checkpoint) and PR #162 (compaction): 1. Timer initialization: DateTime.MinValue → DateTime.UtcNow prevents compaction/archival from firing on the very first collection cycle 2. Inline checkpoint: moved CHECKPOINT to end of RunDueCollectorsAsync using the existing connection pool instead of opening a separate DuckDB instance that conflicts via OS file locks 3. Atomic file swap: replaced two-step File.Move in CompactAsync with File.Replace (single OS operation, no window where the database file is missing) plus retry logic for locked files and WAL cleanup Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DateTime.MinValuetoDateTime.UtcNow— prevents compaction/archival/retention from all firing on the very first collection cycleRunDueCollectorsAsyncinstead of opening a separate DuckDB instance that conflicts via OS file locksFile.MoveinCompactAsyncwith atomicFile.Replace(no window where the database file is missing) plus retry logic for locked filesTest plan
dotnet build -c Debug— 0 warnings, 0 errorsCompactionIntervalfor testing)🤖 Generated with Claude Code