Fix mutex crash on app exit (fixes #89)#158
Merged
erikdarlingdata merged 1 commit intodevfrom Feb 19, 2026
Merged
Conversation
ReleaseMutex() throws ApplicationException if called by a thread that doesn't own the mutex. This happens when the app exits after detecting a second instance, or when shutdown is triggered from a non-owning thread. Track ownership and only release if we own it. Fixed in both Dashboard and Lite. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReleaseMutex()inOnExitthrowsApplicationExceptionwhen called by a thread that doesn't own the mutex_ownsMutexfield — only release if we actually acquired ownershipRoot Cause
When the app detects a second instance, it creates the mutex but doesn't own it, then calls
Shutdown(). DuringOnExit,ReleaseMutex()throws because the calling thread isn't the owner. This is an unhandled exception during shutdown, so it terminates the process.Credit to @jaglick for the stack trace on #89.
Test plan