-
Notifications
You must be signed in to change notification settings - Fork 25
Closed
Labels
questionFurther information is requestedFurther information is requested
Description
Which component is your question about?
- Full Dashboard
- Lite
- SQL collection scripts
- Installer
- General / setup
Version
Performance Monitor Version: 1.1.0
Is your question about how it works, or the results?
About building the C# projects and their NuGet packages.
What's your question?
Hi Erik!
-
Can I raise a PR to update all the NuGet packages to their latest stable version?
I've tested all the affected programs locally and they still build ok (minus the few C# project warnings they already had). -
Am I allowed to also fix the warnings? Want it in a separate PR? I mean stuff like this:
.\build-all.cmd
========================================
Building All Performance Monitor Projects
========================================
========================================
Building Full Edition (Dashboard + Installers)
========================================
Version: 1.1.0
[1/3] Publishing Dashboard...
Restore complete (0.4s)
Dashboard_t32rwwle_wpftmp net8.0-windows succeeded with 1 warning(s) (6.6s)
C:\Repos\Git\PerformanceMonitor\Dashboard\ColumnFilterPopup.xaml.cs(35,43): warning CA2263: Prefer the generic overload 'System.Enum.GetValues<TEnum>()' instead of 'System.Enum.GetValues(System.Type)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2263)
Dashboard net8.0-windows succeeded with 1 warning(s) (12.0s) → publish\Dashboard\
C:\Repos\Git\PerformanceMonitor\Dashboard\ColumnFilterPopup.xaml.cs(35,43): warning CA2263: Prefer the generic overload 'System.Enum.GetValues<TEnum>()' instead of 'System.Enum.GetValues(System.Type)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2263)
Build succeeded with 2 warning(s) in 12.9s
Creating Dashboard ZIP...
[2/3] Publishing CLI Installer...
Restore complete (0.5s)
PerformanceMonitorInstaller net8.0 win-x64 succeeded (5.7s) → Installer\bin\Release\net8.0\win-x64\publish\
Build succeeded in 6.7s
[3/3] Publishing GUI Installer...
Restore complete (0.5s)
InstallerGui net8.0-windows win-x64 succeeded (1.8s) → InstallerGui\bin\Release\net8.0-windows\win-x64\publish\
Build succeeded in 2.9s
Packaging Installer + SQL scripts...
========================================
Build Complete
========================================
Output:
releases\PerformanceMonitorDashboard-1.1.0.zip
releases\PerformanceMonitorInstaller-1.1.0.zip
Dashboard size: 51033617 bytes
Installer size: 33637807 bytes
========================================
Building Performance Monitor Lite
========================================
Version: 1.1.0
Publishing Lite Edition...
Restore complete (0.5s)
PerformanceMonitorLite net8.0-windows succeeded with 67 warning(s) (3.2s) → publish\Lite\
C:\Repos\Git\PerformanceMonitor\Lite\Controls\ColumnFilterPopup.xaml.cs(35,39): warning CA2263: Prefer the generic overload 'System.Enum.GetValues<TEnum>()' instead of 'System.Enum.GetValues(System.Type)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2263)
C:\Repos\Git\PerformanceMonitor\Lite\Database\DuckDbInitializer.cs(149,25): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Database\DuckDbInitializer.cs(41,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Database\DuckDbInitializer.cs(163,21): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Database\DuckDbInitializer.cs(47,21): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Database\DuckDbInitializer.cs(54,21): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Database\DuckDbInitializer.cs(83,25): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Database\DuckDbInitializer.cs(98,21): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Database\DuckDbInitializer.cs(362,29): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Database\DuckDbInitializer.cs(367,25): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\ServerManager.cs(129,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\ServerManager.cs(173,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\ServerManager.cs(196,21): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\ServerManager.cs(295,21): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\ServerManager.cs(378,21): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\ServerManager.cs(390,25): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\ServerManager.cs(407,25): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\ArchiveService.cs(77,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\ArchiveService.cs(124,25): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\ServerManager.cs(543,21): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\ServerManager.cs(477,21): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\ServerManager.cs(500,29): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\ScheduleManager.cs(120,25): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\ScheduleManager.cs(158,21): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\ScheduleManager.cs(186,21): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\ScheduleManager.cs(233,21): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\ScheduleManager.cs(243,25): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RetentionService.cs(60,33): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.BlockedProcessReport.cs(107,25): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.BlockedProcessReport.cs(143,33): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.BlockedProcessReport.cs(155,29): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.BlockedProcessReport.cs(181,21): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\DeltaCalculator.cs(126,32): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\DeltaCalculator.cs(158,32): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.Cpu.cs(123,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\DeltaCalculator.cs(184,32): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\DeltaCalculator.cs(210,32): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.cs(196,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.cs(229,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.cs(275,25): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873) C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.cs(280,21): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873) C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.cs(351,21): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.BlockedProcessReport.cs(411,21): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.BlockedProcessReport.cs(417,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.cs(483,37): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.Deadlocks.cs(97,33): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.Deadlocks.cs(109,29): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.Deadlocks.cs(138,21): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.Deadlocks.cs(370,21): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.Deadlocks.cs(376,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.FileIo.cs(169,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.Memory.cs(174,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.Memory.cs(237,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.MemoryGrants.cs(119,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.Perfmon.cs(187,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.ProcedureStats.cs(273,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.QuerySnapshots.cs(146,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.QueryStats.cs(237,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.QueryStore.cs(165,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.RunningJobs.cs(184,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.ServerConfig.cs(93,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.ServerConfig.cs(180,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.ServerConfig.cs(294,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.ServerConfig.cs(386,21): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.TempDb.cs(103,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.WaitingTasks.cs(96,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
C:\Repos\Git\PerformanceMonitor\Lite\Services\RemoteCollectorService.WaitStats.cs(156,17): warning CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
Build succeeded with 67 warning(s) in 4.5sReactions are currently unavailable
Metadata
Metadata
Assignees
Labels
questionFurther information is requestedFurther information is requested