sp_QuickieStore: split Step 1 aggregate to avoid 4-way DMV join#715
Merged
erikdarlingdata merged 1 commit intodevfrom Mar 24, 2026
Merged
sp_QuickieStore: split Step 1 aggregate to avoid 4-way DMV join#715erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
The initial aggregate query joined all 4 Query Store DMVs together (qsq → qsp → qsrs → qsrsi), causing the optimizer to pick bad plans with TVFs taking 8+ seconds. Split into two stages following the pattern used elsewhere in the proc: - Step 1a: qsrs + qsrsi → #hi_plan_stats (aggregate to plan_id level) - Step 1b: #hi_plan_stats + qsp + qsq → #hi_query_stats (roll up to query_hash, driving from a small pre-aggregated temp table) Tested on SQL2022 (StackOverflow2013) and SQL2016 (StackOverflow2010). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split the initial 4-way DMV join (qsq → qsp → qsrs → qsrsi) into two stages:
Follows the pattern used elsewhere in sp_QuickieStore where Query Store views are touched individually or in small groups.
Test plan
🤖 Generated with Claude Code