sp_QuickieStore: fix @find_high_impact step ordering#710
Merged
erikdarlingdata merged 1 commit intodevfrom Mar 24, 2026
Merged
Conversation
…un after #hi_interesting Steps 2b/2c (query_id staging + representative text) were placed before Step 2 (top N → #hi_interesting), so #hi_id_staging_queries joined an empty #hi_interesting table. This caused NULL primary_window, query_id_list, and empty query_sql_text. Moved Steps 3b/3c to after Step 3 (scoring) where #hi_interesting is populated. Tested on SQL2022 and SQL2016 — all columns populated correctly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes NULL primary_window, query_id_list, and empty query_sql_text caused by query_id staging running before #hi_interesting was populated. Moved staging + representative text to after scoring step.
Test plan
🤖 Generated with Claude Code