sp_QuickieStore: optimize representative text and plan fetch in @find_high_impact#709
Merged
erikdarlingdata merged 3 commits intodevfrom Mar 24, 2026
Merged
Conversation
sp_QuickieStore: optimize time bucketing in @find_high_impact
Representative text (ranked_hash, ~23s): - Moved query_id staging to run immediately after #hi_interesting - Representative text query now starts from #hi_id_staging_queries (pre-filtered interesting hashes) instead of scanning all runtime stats rows (1.7M → ~10K) Final SELECT plan fetch (~29s): - Replaced TOP (1) ... ORDER BY with ROW_NUMBER() ... WHERE n = 1 in the OUTER APPLY to give the optimizer better options for the correlated subquery Tested on SQL2022 (SO2013, TPC-H) and SQL2016 (SO2010). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two performance fixes based on actual execution plan analysis:
Representative text query (~23s → fast)
#hi_id_staging_queriesinstead of scanning all 1.7M runtime stats rows through the full 4-table DMV chainFinal SELECT plan fetch (~29s → TBD)
TOP (1) ... ORDER BYwithROW_NUMBER() ... WHERE n = 1in the OUTER APPLY to give the optimizer better plan choices for the correlated subqueryTest plan
🤖 Generated with Claude Code